Move the _Unicode module into _StringProcessing #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milseman
reviewed
Feb 3, 2022
| dependencies: ["GenUtils"] | ||
| ) | ||
| ] | ||
| ) |
There was a problem hiding this comment.
It can be part of the string processing package if you feel it should be, but it's a pretty stand alone package that is very severable.
Are the generated files Swift files? Are these generated manually or by the build system? |
|
@milseman are you referring to the _Unicode source files being added to _StringProcessing, or the future c files for Unicode data? |
git ignore stuff
Azoy
force-pushed
the
unicode-but-in-sp
branch
from
145e5af to
69f2798
Compare
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the _Unicode target and instead moves those files into the _StringProcessing target as a sub folder.